Enhancement/41 Podcasts Taxonomy term(s) added in block settings#183
Enhancement/41 Podcasts Taxonomy term(s) added in block settings#183faisal-alvi merged 3 commits intodevelopfrom
Conversation
peterwilsoncc
left a comment
There was a problem hiding this comment.
This looks good to me but I think it might be possible to simplify the code by using the Gutenberg components.
assets/js/edit.js
Outdated
| const ALLOWED_MEDIA_TYPES = [ 'audio' ]; | ||
|
|
||
| // Import taxonomy panel. | ||
| import PostTaxonomies from './taxonomy-panel'; |
There was a problem hiding this comment.
Nit: I'd give the component and file the same name: either PostTaxonomies from './post-taxonomies' or TaxonomyPanel from ...
assets/js/taxonomy-panel/index.js
Outdated
| */ | ||
| import TaxonomyPanel from './taxonomy-panel'; | ||
|
|
||
| function PostTaxonomies() { |
There was a problem hiding this comment.
Is it possible to simplify this with <HierarchicalTermSelector slug="podcasting_podcasts" /> similar to how the category selector is shown on the post-publish-check page (but without the messy checking of whether or not to display it)?
|
@peterwilsoncc thanks for the suggestion, I have implemented
|
peterwilsoncc
left a comment
There was a problem hiding this comment.
Thank you, this LGTM with one suggestion to add a todo.
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
|
@faisal-alvi is this good to come out of Draft (and then get merged in)? |
Description of the Change
Closes #41
Alternate Designs
Possible Drawbacks
show_in_rest: true, we can not replicate it under the settings tab too. If we still need that removed, we may have to adddisplay: noneto it.Verification Process
npm run build.Checklist:
Changelog Entry
Credits
Props @helen @jeffpaul @faisal-alvi