Conversation
… better. Add missing escaping
ravinderk
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
While reviewing #148 I noticed there was some code that was no longer being used. I tracked that down to #129, where we refactored a few things but left some code in place that wasn't actually being used.
While putting together this PR to remove that code, I also noticed we had missing escaping in one place and that a couple of our text strings we show could be translated slightly better, so all of those have been fixed here.
So the things this PR does:
screen_id, as the underlying code was removed in Add functionality to reset page order #129 but some code was left in placepostHow to test the Change
pagepost type)Helptab and click on theSimple Page OrderingtabChangelog Entry
Credits
Props @dkotter
Checklist: