Ensure the add_new and add_new_item labels are the same#404
Merged
Conversation
jeffpaul
approved these changes
Nov 12, 2024
Member
jeffpaul
left a comment
There was a problem hiding this comment.
Looks good, waiting on e2e tests to pass before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
In testing on WP 6.7, the Add New button for the Safe Redirect Manager post type is showing as
Safe Redirect Managerinstead ofCreate Redirect Rule. This causes an E2E failure and also doesn't make much sense, since this button shows right next to the title which is also Safe Redirect Manager.Seems WP 6.7 changed something around the
add_newandadd_new_itemlabels so this PR ensures our post type uses the same text for both.Before on WP 6.7:
After on WP 6.7 (and older):
How to test the Change
Create Redirect RuleChangelog Entry
Credits
Props @dkotter, @jeffpaul
Checklist: