Conversation
Closed
fabiankaegy
approved these changes
Jul 23, 2024
Member
fabiankaegy
left a comment
There was a problem hiding this comment.
This is a nice little improvement and the code look good to me :)
I was unaware by how much of the UI is coming from the Library we are using here. That is a real bummer. But still this is a step in the right direction :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This update moves makes the interface more consistent with the core UI by consistent padding to the toolbar button and popover element.
Before:
After:
Closes #231
How to test the Change
Changelog Entry
Changed UI to have padding consistent with WP Core
Credits
@psorensen @fabiankaegy
Checklist: