Clean up NPM dependencies and update node to v20#238
Merged
Sidsector9 merged 3 commits intodevelopfrom Jan 31, 2024
Merged
Conversation
cde769f to
886f228
Compare
dkotter
requested changes
Jan 30, 2024
tests/cypress/config.js
Outdated
| const cacheDirectory = await getCacheDirectory(); | ||
| const wpEnvConfig = await loadConfig( cacheDirectory ); | ||
|
|
||
| console.log(wpEnvConfig.env.tests.config.WP_SITEURL) |
Collaborator
There was a problem hiding this comment.
Assuming this isn't needed
Collaborator
|
@Sidsector9 Seeing some E2E failures here. I'm assuming those aren't related to this upgrade but could you confirm that? |
886f228 to
5cf3a0f
Compare
dkotter
approved these changes
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR cleans up NPM dependencies and updates the node version to
20.11.0Closes #237
Changelog Entry
Credits
Props @Sidsector9
Checklist: