Skip to content

fix/caret: Fix caret and formatting issue#225

Merged
Sidsector9 merged 8 commits intodevelopfrom
fix/caret-reversal
Nov 7, 2023
Merged

fix/caret: Fix caret and formatting issue#225
Sidsector9 merged 8 commits intodevelopfrom
fix/caret-reversal

Conversation

@Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Oct 20, 2023 •
edited
Loading

Description of the Change

Closes #34
Closes #208

How to test the Change

Please see the respective issues for testing instructions.

Changelog Entry

Fixed - Issue with blocks crashing due to faux caret
Fixed - Issue with characters added to the beginning trimming text from the end

Credits

Props @dkotter @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Sidsector9 Sidsector9 requested a review from a team as a code owner October 20, 2023 08:15
@Sidsector9 Sidsector9 requested review from peterwilsoncc and removed request for a team October 20, 2023 08:15
@jeffpaul jeffpaul added this to the 1.2.0 milestone Oct 20, 2023
@ankitguptaindia
Copy link
Member

ankitguptaindia commented Oct 30, 2023

@Sidsector9 This PR fixed the issues reported in both connected issues but I am facing issue in a specific scenario when user select whole content which has any special character.

It is showing This block has encountered an error and cannot be previewed.

Screenshot 2023-10-30 at 10 18 22 PM

Issue.mp4
Details For QA Use only: RTL Sites:
RTL.mp4

@ankitguptaindia
Copy link
Member

ankitguptaindia commented Nov 4, 2023 •
edited
Loading

QA/Test Report- ✅

Testing Environment -

  • WordPress: 6.5-alpha-57029
  • PHP: 8.0.30
  • Server: nginx/1.16.0
  • Database: mysqli (Server: 5.7.28 / Client: 8.0.30)
  • Browser: Chrome 118.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Four 1.0

Actual Results

  • Both Connected issues have been fixed. ✅
  • Issue Reported in QA Feedback has been addressed and fixed. ✅
  • Also tested in RTL & LTR sites, issues have been fixed. ✅
ISC.mp4

@ankitguptaindia ankitguptaindia mentioned this pull request Nov 4, 2023
Closed
@Sidsector9 Sidsector9 merged commit 302fece into develop Nov 7, 2023
@Sidsector9 Sidsector9 deleted the fix/caret-reversal branch November 7, 2023 15:07
@Sidsector9 Sidsector9 mentioned this pull request Nov 7, 2023
Closed
1 task
@dkotter dkotter modified the milestones: 1.2.0, 1.1.2 Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitguptaindia ankitguptaindia ankitguptaindia approved these changes

@peterwilsoncc peterwilsoncc Awaiting requested review from peterwilsoncc peterwilsoncc was automatically assigned from 10up/open-source-practice

Assignees

@Sidsector9 Sidsector9

Labels

None yet

Projects

None yet

Milestone

1.1.2

Development

Successfully merging this pull request may close these issues.

Adding characters to the beginning trims text from the end Show a "cursor" in the editor while popover is open

4 participants

@Sidsector9 @ankitguptaindia @dkotter @jeffpaul