Ensure the attributes.content param exists before using it#220
Closed
Ensure the attributes.content param exists before using it#220
attributes.content param exists before using it#220Conversation
Collaborator
Author
|
@Sidsector9 Tagging you in for a review here since you worked on the changes in #207. The changes here seem to fix the reported issue but not sure if this is the best approach or not (read through the PR description for full details on that). Thanks! |
Collaborator
Author
|
@Sidsector9 As a quick follow up here, I tested the previously released version (v1.0.7) with Spectra Blocks and you can insert special characters within their blocks. So while this PR fixes the immediate issue of crashes, there's still a separate regression where special characters aren't inserted properly, which I imagine probably impacts other blocks. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
As described on WordPress.org, with the latest update, some blocks are crashing. I installed the plugin mentioned (Spectra Blocks) and when using the blocks that plugin adds (like Call to Action) I was able to reproduce the reported issue.
The problem stems from the work done in #207, in particular this line: https://github.com/10up/insert-special-characters/pull/207/files#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556R117. It seems some blocks don't have the
attributes.contentset, so when we try and access that, it throws a JS error and prevents the block from working.I've fixed that in this PR but ensuring that data exists before we try to use it and that does seem to fix the reported issue. I'm not sure if it's the best approach though or if there's a better way to handle this. In addition, while this prevents the block from breaking, the toolbar is still shown but doesn't seem to work. Not sure if there's a way to make the toolbar work in this instance or if there's a way to remove the toolbar all together? Not sure if this is an instance where we could be doing something different or if it's an issue with how these custom blocks are built, since they don't seem to have the standard
contentattribute.How to test the Change
Changelog Entry
Credits
Props @dkotter
Checklist: