Fix an issue where highlighting a format would error#204
Merged
dkotter merged 1 commit into10up:developfrom Jul 12, 2023
jrmd:fix/highlight-error
Merged
Fix an issue where highlighting a format would error#204dkotter merged 1 commit into10up:developfrom jrmd:fix/highlight-error
dkotter merged 1 commit into10up:developfrom
jrmd:fix/highlight-error
Conversation
dkotter
approved these changes
Jul 12, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fixes an issue where highlighting a newly inserted special character that has no formatting will cause the block to error. The change alters how the character is inserted by specifically targeting the correct start/end and setting the formats array to an empty array instead of
[ undefined ](the source of the error).Closes #203
How to test the Change
Video of the change in action
Screen.Recording.2023-07-12.at.14.34.48.mov
Changelog Entry
Checklist: