Conversation
dkotter
requested changes
Aug 16, 2024
Collaborator
dkotter
left a comment
There was a problem hiding this comment.
So this works (well it will work once the plugin is on .org) but it just lands you on a blank edit screen. I'd suggest for a better experience, we actually create a page that has the Figma Block, with an actual Figma URL already set in the block. This will be a better preview experience than forcing someone to add the block themselves
dkotter
requested changes
Aug 20, 2024
| } | ||
| }, | ||
| { | ||
| "step": "importFile", |
Collaborator
There was a problem hiding this comment.
importFile has been deprecated and this should be importWxr instead
| "step": "importFile", | ||
| "file": { | ||
| "resource": "url", | ||
| "url": "https:\/\/raw.githubusercontent.com\/10up\/figma-block\/05a11e7ed51038173610e543cb02fc56024f0c1f\/.wordpress-org\/blueprints\/demo-data.xml" |
Collaborator
There was a problem hiding this comment.
We'll probably want to ensure this URL get's updated to point to develop before this is merged
dkotter
approved these changes
Aug 21, 2024
jeffpaul
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #27
How to test the Change
Changelog Entry
Credits
Props @jeffpaul, @thrijith
Checklist: