Merged
Conversation
Collaborator
Author
|
Note: This PR is branched off #52 as it depends on the earlier work. Here is the diff of the changes, feature/add-export-command...feature/detect-classic-editor-posts |
Sidsector9
previously approved these changes
May 8, 2024
Member
Sidsector9
left a comment
There was a problem hiding this comment.
Works as expected 👍
Merge #52 before this PR as there are some changes requested in 52.
Collaborator
Author
|
@Sidsector9 I've fixed that issue, can you take another look? thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds support for detecting Classic Editor blocks mixed with Gutenberg Blocks. This allows Block Catalog to find both legacy Classic Editor posts and posts that have other Gutenberg blocks alongside Classic Editor content.
How to test the Change
Run the Block Catalog index with content that uses Classic Editor or has hybrid content. Or view the blocks for a post via CLI. You should see a Core > Classic block for that post in the block catalog taxonomy.
Output for a Classic Editor Post & a Hybrid Post:
Changelog Entry
Added - Classic Editor block detection
Credits
Props @dsawardekar
Checklist: