Merged
Conversation
Sidsector9
previously approved these changes
Jan 22, 2024
Member
|
@Sidsector9 @dsawardekar looks like an ESLint run failure, potentially affect from merging in #43 |
1f04da0 to
0aaf780
Compare
Sidsector9
approved these changes
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR significantly improves performance of the delete index operation. On a large site with thousands of posts it can taken an hour or to delete the index, because we iterate over each term one at a time. Instead this PR refactors the delete index logic to use direct database queries.
How to test the Change
wp block-catalog delete-indexfaster_catalog_reset.webm
Changelog Entry
Changed - Significantly improved performance of block catalog reset on larger WordPress installations
Credits
Props @dsawardekar
Checklist: