Conversation
…name and PHP version we test on
jeffpaul
approved these changes
Oct 18, 2023
Member
jeffpaul
left a comment
There was a problem hiding this comment.
Looks good, thanks for getting this added in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds our (semi) standard workflow to run PHP compatibility scanning. While this can run as part of the PHPCS scanning, this PR removes the PHPCompatibilityWP standard from our normal PHPCS scanning and adds a new workflow just for that. Open to opinions on if these should be separated or not, the one benefit is it makes it clear when there's a normal PHPCS issue and when there's a compatibility issue.
This compat Action does the following:
developor code is pushed todeveloportrunkcomposer installand then lints any of the changed PHP files, using our php-compat.xml standardCloses #16
How to test the Change
Can see a commit with no PHP changes here: https://github.com/10up/block-catalog/pull/22/checks?sha=010716195d0bb33168772f5c709d40035263b288
Can see a commit with a failing PHP compat check but successful PHPCS check here: https://github.com/10up/block-catalog/pull/22/checks?sha=1ab8288f9996fc7e104876f272d7518f835445d3
Changelog Entry
Credits
Props @dkotter
Checklist: