Merged
Conversation
1. Make `id` more descriptive so there's less chance of a name clash. 2. Update to version 4 of the `upload-artifact` action, as [that brings with it the rather cool option to get the artifact URL immediately](actions/upload-artifact#50 (comment)).
dkotter
approved these changes
Jan 24, 2024
Collaborator
dkotter
left a comment
There was a problem hiding this comment.
Thanks! This looks good to me
|
I would also like to see this merged, is there anything I can do to make it happen? Edit: Thank you! |
4 tasks
This was referenced Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
idmore descriptive so there's less chance of a name clash.upload-artifactaction, as that brings with it the rather cool option to get the artifact URL immediately.Closes #2
How to test the Change
Not 100% sure :)
Changelog Entry
Checklist: