crates/starknet-devnet-types/src/patricia_key.rs (1)

22-23: Guard the unchecked constructor with a debug assertion and add a safety note.

Helps catch accidental out-of-range uses in dev builds and documents the invariant.

 impl PatriciaKey {
@@
-        Ok(Self(felt))
+        Ok(Self(felt))
     }
 
-    pub(crate) fn new_unchecked(felt: Felt) -> Self {
-        Self(felt)
+    /// Constructs without range checks.
+    /// Safety: `felt` must be in [0x0, PATRICIA_KEY_UPPER_BOUND).
+    pub(crate) fn new_unchecked(felt: Felt) -> Self {
+        debug_assert!(
+            Felt::from_hex_unchecked(PATRICIA_KEY_UPPER_BOUND) >= felt,
+            "PatriciaKey out of range"
+        );
+        Self(felt)
     }

Also applies to: 25-26

crates/starknet-devnet-types/src/rpc/contract_address.rs (1)

20-22: Document the unchecked constructor.

Clarify caller responsibility to maintain invariants.

-    pub fn new_unchecked(felt: Felt) -> Self {
+    /// Constructs a ContractAddress without range checks.
+    /// Safety: `felt` must satisfy PatriciaKey bounds.
+    pub fn new_unchecked(felt: Felt) -> Self {
         Self(PatriciaKey::new_unchecked(felt))
     }

crates/starknet-devnet-server/src/api/error.rs (1)

87-89: Confirm UX choice for InvalidAddress message.

Mapping returns only the inner msg (without the "Invalid address:" prefix). If intentional for cleaner client messages, keep as is; otherwise switch to error_message for consistency with other variants.

Would you like a small unit test asserting the RPC mapping for InvalidAddress? I can add one similar to existing tests.

Also applies to: 287-291

crates/starknet-devnet-server/src/api/account_helpers.rs (1)

60-65: Good switch to non-fallible ERC20 helper and validating tests.

• Helper now clearly reflects deterministic mapping of FeeUnit -> ERC20 address.
• Tests ensure constants remain in range for both checked/unchecked paths.

Optional: add doc comment on get_erc20_fee_unit_address noting it relies on canonical, compile-time constants.

Also applies to: 72-76, 80-105

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: FabijanC
PR: 0xSpaceShard/starknet-devnet#799
File: crates/starknet-devnet-core/src/starknet/mod.rs:240-246
Timestamp: 2025-06-16T07:35:24.725Z
Learning: In the Starknet devnet codebase, `get_class_hash_at` has different behaviors at different layers: at the internal state level (blockifier), it returns `Ok(ClassHash(Felt::ZERO))` for undeployed addresses, while at the RPC layer, this gets converted to `Err(Error::ContractNotFound)`. When checking if a contract is deployed at the internal state level, use `is_ok_and(|h| h.0 == Felt::ZERO)` to detect undeployed addresses.

Learnt from: FabijanC
PR: 0xSpaceShard/starknet-devnet#799
File: crates/starknet-devnet-core/src/starknet/mod.rs:240-246
Timestamp: 2025-06-16T07:35:24.725Z
Learning: In the Starknet devnet codebase, `get_class_hash_at` has different behaviors at different layers: at the internal state level (blockifier), it returns `Ok(ClassHash(Felt::ZERO))` for undeployed addresses, while at the RPC layer, this gets converted to `Err(Error::ContractNotFound)`. When checking if a contract is deployed at the internal state level, use `is_ok_and(|h| h.0 == Felt::ZERO)` to detect undeployed addresses.