Skip to content

Support general JSON-RPC API via websockets#844

Merged
FabijanC merged 12 commits intomainfrom
general-rpc-via-ws
Sep 15, 2025
Merged

Support general JSON-RPC API via websockets#844
FabijanC merged 12 commits intomainfrom
general-rpc-via-ws

Conversation

@FabijanC
Copy link
Copy Markdown
Contributor

@FabijanC FabijanC commented Sep 10, 2025

Usage related changes

Development related changes

  • Reorganize RPC request enums.
  • Remove lazy_static from starknet-devnet-server by simplifying the implementation of the list of default restricted RPC methods
  • Remove unused deploy_account_str util fn
  • Modify crates/starknet-devnet-server/src/test_utils::assert_contains to return unwrappable Result instead of panicking
  • Un-ignore the existing general RPC support tests
    • They were added back when ws support was originally introduced, when we thought we would have general RPC support
  • I couldn't think of anything better, so I left a reminder with If adding a new variant to the JsonRpcRequest enum.

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Sep 10, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch general-rpc-via-ws

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@FabijanC FabijanC changed the title Support whole JSON-RPC API via websockets Support general JSON-RPC API via websockets Sep 12, 2025
@FabijanC FabijanC marked this pull request as ready for review September 12, 2025 15:33
@FabijanC
Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@FabijanC FabijanC requested a review from 3alpha September 12, 2025 15:33
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Sep 12, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@FabijanC FabijanC merged commit 94abc60 into main Sep 15, 2025
1 check passed
@FabijanC FabijanC deleted the general-rpc-via-ws branch September 15, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable general JSON-RPC support via websockets

2 participants