Skip to content

Test case: set time when pre-confirmed txs#806

Merged
FabijanC merged 2 commits intomainfrom
test-pre-confirmed-set-time
Jul 9, 2025
Merged

Test case: set time when pre-confirmed txs#806
FabijanC merged 2 commits intomainfrom
test-pre-confirmed-set-time

Conversation

@FabijanC
Copy link
Copy Markdown
Contributor

@FabijanC FabijanC commented Jul 8, 2025 •
edited by coderabbitai bot
Loading

Usage related changes

N/A

Development related changes

  • Expand testing as the title suggests.
  • Motivated by this Slack thread.
  • Add utility for equality comparison with the same buffer used in inequality assertion.

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

Summary by CodeRabbit

  • Tests
    • Added a new test to verify transaction and timestamp consistency when advancing time with pre-confirmed transactions under demand block generation mode.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jul 8, 2025 •
edited
Loading

Walkthrough

A new helper function, assert_eq_with_buffer, was introduced to compare two u64 values within a specified buffer. An asynchronous test, set_time_with_pre_confirmed_txs, was added, which initializes a devnet with block generation set to "demand," sends two mint transactions, and verifies that the transactions and timestamps in both the pending and latest blocks are consistent and within the defined buffer when the blockchain time is advanced. The changes focus on testing transaction and timestamp behavior under specific block generation and time advancement scenarios.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Clippy (1.86.0) 
Updating crates.io index
Updating git repository `https://github.com/starkware-libs/sequencer.git`

error: failed to get blockifier as a dependency of package starknet-devnet-types v0.4.3 (/crates/starknet-devnet-types)

Caused by:
failed to load source for dependency blockifier

Caused by:
Unable to update https://github.com/starkware-libs/sequencer.git?rev=3f010d153731dcb8f118403d96390933909bb4a6#3f010d15

Caused by:
failed to create directory /usr/local/git/db/sequencer-77397f56b8742484

Caused by:
Permission denied (os error 13)

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e08301f and dc88c09.

📒 Files selected for processing (1)
  • tests/integration/test_advancing_time.rs (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings 
Learnt from: FabijanC
PR: 0xSpaceShard/starknet-devnet#755
File: crates/starknet-devnet-server/test_data/spec/0.8.1/starknet_executables.json:1154-1168
Timestamp: 2025-04-14T09:33:59.391Z
Learning: FabijanC wants to configure CodeRabbit to ignore spec files from review, specifically the JSON schema files in the test_data/spec directory.
🧬 Code Graph Analysis (1)
tests/integration/test_advancing_time.rs (3)
tests/integration/common/utils.rs (2)
  • get_unix_timestamp_as_seconds (169-174)
  • set_time (671-676)
tests/integration/common/background_anvil.rs (1)
  • spawn_with_additional_args (80-87)
tests/integration/common/background_devnet.rs (1)
  • spawn_with_additional_args (143-170)
🔇 Additional comments (2)
tests/integration/test_advancing_time.rs (2)

45-50: LGTM! Well-designed helper function fills a testing gap.

The assert_eq_with_buffer function correctly implements equality assertion with buffer tolerance using abs_diff, which is the appropriate method for u64 values. This complements the existing assert_ge_with_buffer and assert_gt_with_buffer functions, providing consistent buffer-based assertions across the test suite.

311-339: LGTM! Comprehensive test covers the intended scenario.

The test effectively validates the consistency of transactions and timestamps when time is advanced with pre-confirmed transactions under demand block generation. The test structure is well-organized with clear phases:

  1. Setup with demand block generation
  2. Send transactions and verify pending block state
  3. Advance time and verify latest block state

The sorting of transaction arrays ensures deterministic equality comparisons, and the use of both assert_eq_with_buffer and assert_ge_with_buffer provides appropriate timestamp validation for different scenarios.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@FabijanC
Copy link
Copy Markdown
Contributor Author

FabijanC commented Jul 8, 2025

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jul 8, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@FabijanC FabijanC merged commit 0fe6515 into main Jul 9, 2025
1 check passed
@FabijanC FabijanC deleted the test-pre-confirmed-set-time branch July 9, 2025 07:48
@coderabbitai coderabbitai bot mentioned this pull request Jul 9, 2025
Closed
10 tasks
@coderabbitai coderabbitai bot mentioned this pull request Jul 17, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@FabijanC