Add dummy starknet_getStorageProof, remove unused Serialize#659
Merged
FabijanC merged 3 commits intojson-rpc-v0.8.0from Dec 10, 2024
Merged
Add dummy starknet_getStorageProof, remove unused Serialize#659FabijanC merged 3 commits intojson-rpc-v0.8.0from
starknet_getStorageProof, remove unused Serialize#659FabijanC merged 3 commits intojson-rpc-v0.8.0from
Conversation
starknet_getStorageProofstarknet_getStorageProof, remove unused Serialize
marioiordanov
approved these changes
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage related changes
Development related changes
starknet_getStorageProofis set to be a dummyserde_json::Valuesince that case should never happen.starknet_getStorageProofto serve at least as a structure verifier for users wanting to test interaction with this endpoint.Serializederivations on RPC input structs.is_forwardable_to_originto returntrueforstarknet_getStorageProofin case it's called with an old origin block.Checklist:
./scripts/format.sh./scripts/clippy_check.sh./scripts/check_unused_deps.sh./scripts/check_spelling.sh./website/README.md