Add WebSocket RPC methods: subscribeNewHeads, unsubscribe#634
Merged
FabijanC merged 42 commits intojson-rpc-v0.8.0from Nov 8, 2024
Merged
Add WebSocket RPC methods: subscribeNewHeads, unsubscribe#634FabijanC merged 42 commits intojson-rpc-v0.8.0from
FabijanC merged 42 commits intojson-rpc-v0.8.0from
Conversation
marioiordanov
suggested changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage related changes
starknet_subscribeNewHeadsandstarknet_unsubscribe.todo!.main.rswhich prevented SIGINT from killing Devnet instantly in block-on-interval mode.starknet_getNonceordevnet_mintare no longer supported via WebSocket. Apparently they never should have been, onlystarknet_(un)subscribemethods should be available via this protocol.mainbranch.Development related changes
i64.rand::random()to find occurrences of this.JsonRpcHandler:to_json_rpc_requestallows_methodwhich checks restrictedness, relying on previously definedis_json_rpc_method_restrictedapiproperty with asocketsmap.Boxing of enum variants.TooManyBlocksBackis not tested because I couldn't make it generate 1024 blocks efficiently.Checklist:
./scripts/format.sh./scripts/clippy_check.sh./scripts/check_unused_deps.sh./scripts/check_spelling.sh./website/README.md