starknet_getCompiledCasm#633
Merged
marioiordanov merged 10 commits intojson-rpc-v0.8.0from Oct 28, 2024
Merged
Conversation
FabijanC
suggested changes
Oct 28, 2024
| let class_hash = | ||
| devnet.json_rpc_client.get_class_hash_at(block_id, account_address).await.unwrap(); | ||
|
|
||
| get_compiled_casm(&devnet, block_id, class_hash).await.unwrap(); |
Contributor
There was a problem hiding this comment.
Why not assert the returned value? E.g. the request could be succeeding if we mistakenly return the Default implementation of CasmContractClass from the endpoint.
FabijanC
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage related changes
Development related changes
Checklist:
./scripts/format.sh./scripts/clippy_check.sh./scripts/check_unused_deps.sh./scripts/check_spelling.sh./website/README.md