Skip to content

Core/predeployed accounts#6

Merged
marioiordanov merged 87 commits intomainfrom
core/predeployed_accounts
Jun 28, 2023
Merged

Core/predeployed accounts#6
marioiordanov merged 87 commits intomainfrom
core/predeployed_accounts

Conversation

@marioiordanov
Copy link
Copy Markdown
Contributor

@marioiordanov marioiordanov commented Jun 9, 2023

  • Predeployed accounts
  • UDC, ERC20 Cairo 0 account deployed
  • CLI

Organising the StarknetWrapper was not a goal for this PR, because there is not so much to organise. But the plan is to have one object like StarknetWrapper that holds references to state, blocks, transactions, accounts. Then with all the logic coming to this class it will become larger so the idea is to split the implementation of this StarknetWrapper like object to multiple files, each file will be responsible for a group of "service" methods. Then those methods will interact with the properties of the StarknetWrapper like object. The goal for each method is to combine set of invocations to the members of StarknetWrapper, so we can keep each "service" method not so big.

After running cargo run, there is a warning for [dead_code] for the state member of Starknet struct. This happens, because when constructing Starknet object, the state member is being assigned to the object after all of the changes to it and in this PR there are no interactions with the state property of Starknet struct in any of the other methods (currently there are 2 - new, get_predeployed_accounts)

@marioiordanov marioiordanov requested a review from FabijanC June 27, 2023 19:27
@marioiordanov marioiordanov merged commit 452e76a into main Jun 28, 2023
@ivpavici ivpavici linked an issue Jun 28, 2023 that may be closed by this pull request
@marioiordanov
Copy link
Copy Markdown
Contributor Author

marioiordanov commented Jun 28, 2023

Closes #1

@marioiordanov
Copy link
Copy Markdown
Contributor Author

Closes #2

@marioiordanov marioiordanov linked an issue Jun 28, 2023 that may be closed by this pull request
@marioiordanov marioiordanov deleted the core/predeployed_accounts branch July 6, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add UDC and ERC20 contracts to predeployment Predeployed accounts

4 participants