This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Closed
Conversation
steveklebanoff
commented
Jun 23, 2020
src/utils/number_utils.ts
Outdated
| // creates a random number of desired length by stringing together | ||
| // random integers from 1-9, guaranteeing the | ||
| // the .toString().length of the return value to equal to numberLength parameter | ||
| randomNumberOfLength: (numberLength: number): number => { |
Contributor
Author
There was a problem hiding this comment.
I know there are cooler and faster ways to achieve this (i.e. https://stackoverflow.com/a/3437180) but I wanted to guarantee that .toString().length = 10 so that we could correctly grab the following timestamp even in 300 years when unixTimestampInSeconds.toString().length is 11 😉
Contributor
Author
|
Upon further review of the data pipeline, I'm going to push up some commits that revise this to take the |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hijacks the timestamp calldata to be treated as unique id:
[10 random numbers][timestamp in seconds]This will allow us to more easily attribute data in our data pipeline, and communicate unique ids for quotes to RFQT market makers
Testing Instructions
Checklist
[WIP]if necessary.