Conversation
7dbea21 to
7b6b457
Compare
Also: - fix tests
| signature, | ||
| protocolFee, | ||
| ); | ||
| res.status(HttpStatus.TOO_MANY_REQUESTS).send({ |
There was a problem hiding this comment.
Todo: we should document that the caller can submit this themselves when rate limited. Janky experience but works better with rfqt then another fresh quote? Or maybe just quote in normal flow. Not sure
- add env-cmd as a dependency
dekz
left a comment
There was a problem hiding this comment.
lookin good to me, few changes but after that I think we're ready to roll.
| public expectedMinedInSec?: number; | ||
|
|
||
| @Column({ name: 'gas_price', type: 'varchar', nullable: true, transformer: BigNumberTransformer }) | ||
| @Column({ name: 'gas_price', type: 'bigint', nullable: true, transformer: BigNumberTransformer }) |
There was a problem hiding this comment.
we'll need to migrate these prior to deploy I imagine?
There was a problem hiding this comment.
the autosync should handle the fields, I've tried to autogenerate the migration files using typeorm CLI but failed.. might take another look.
But if anything we can test if auto-sync will work before deploying to production, and just create an "init" migration for now.
| @@ -0,0 +1,33 @@ | |||
| import { assert } from '@0x/assert'; | |||
There was a problem hiding this comment.
src/utils/rate_limiters/base_db_limiter.ts
src/utils/rate-limiters/meta_transaction_composable_rate_limiter.ts
Outdated
Show resolved
Hide resolved
|
deploy staging |
|
merged #270 |
Description
Testing Instructions
Checklist
[WIP]if necessary.