Skip to content

Including ws address#323

Merged
lucca30 merged 2 commits intoheimdall-v2from
lmartins/milestone-ws-events
Mar 11, 2025
Merged

Including ws address#323
lucca30 merged 2 commits intoheimdall-v2from
lmartins/milestone-ws-events

Conversation

@lucca30
Copy link
Copy Markdown
Contributor

@lucca30 lucca30 commented Mar 6, 2025

Description

Include new WSAddress flag in node to allow listening to milestone events.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewers or the whole pos-v1 team
  • I have added sufficient documentation in the code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

It should never be the case...

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai or amoy

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@lucca30 lucca30 requested review from a team, Raneet10 and avalkov March 6, 2025 14:55
@lucca30 lucca30 changed the base branch from raneet10/heimdallv2-test to heimdall-v2 March 6, 2025 15:07
@marcello33
Copy link
Copy Markdown
Contributor

Hey @lucca30 can you apply such changes to the docker setup as well?
We have the specular templates for docker

@lucca30
Copy link
Copy Markdown
Contributor Author

lucca30 commented Mar 6, 2025

Thanks @marcello33 , applied on ba35aaf

@lucca30 lucca30 merged commit 3a18ecb into heimdall-v2 Mar 11, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants