Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the backfill spans functionality from the codebase, including related message types, handlers, and supporting infrastructure. The backfill feature was used to synchronize spans between Heimdall and Bor when Heimdall was down and Bor self-committed spans.
- Deletes
MsgBackfillSpansmessage type and its handlers - Removes backfill logic from the span processor
- Eliminates supporting utility functions and tests
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
x/bor/types/util_test.go |
Complete deletion of test file for CalcCurrentBorSpanId function |
x/bor/types/msg.go |
Removes MsgBackfillSpans message type and constructor |
x/bor/keeper/side_msg_server.go |
Simplifies backfill handler to always return Vote_VOTE_NO |
x/bor/grpc/query.go |
Removes GetStartBlockHeimdallSpanID gRPC client method |
x/bor/client/cli/tx.go |
Deletes CLI command for backfill spans transactions |
helper/mocks/i_contract_caller.go |
Removes mock for GetStartBlockHeimdallSpanID interface method |
helper/call.go |
Removes contract caller interface method and implementation |
bridge/processor/span.go |
Removes backfill logic from span processor and simplifies flow |
kamuikatsurgi
approved these changes
Jul 22, 2025
pratikspatil024
approved these changes
Aug 6, 2025
|
|
@avalkov So, New logic won't be implemented or backfilling spans won't be supported forever in upcoming release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Delete spans backfill logic.