Skip to content
This repository was archived by the owner on Jul 15, 2025. It is now read-only.

Daniel/inc 2109#875

Merged
cffls merged 13 commits into
qafrom
daniel/INC-2109
Nov 23, 2022
Merged

Daniel/inc 2109#875
cffls merged 13 commits into
qafrom
daniel/INC-2109

Conversation

@djpolygon

@djpolygon djpolygon commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

This draft PR is a placeholder for some testing purposes related to addition to checksum, package signing, and creation of rpm/deb packages.

This is a work in progress.

@djpolygon

Copy link
Copy Markdown
Contributor Author

Still working on rpm spec files and confirming deb packages work correctly via docker.

@temaniarpit27

Copy link
Copy Markdown
Contributor

Hi
Can you please raise an issue regarding this PR with the purpose and description of the feature you are trying to implement?

…g new action for the deb creations. Added a packaging directory to store necessary files to create the deb packages and rpm's. Created templates to store the service configs for use till toml migrations are 100% done
@codecov-commenter

codecov-commenter commented Sep 22, 2022

Copy link
Copy Markdown

Codecov Report

Base: 73.82% // Head: 75.61% // Increases project coverage by +1.79% 🎉

Coverage data is based on head (e409ca4) compared to base (85aee8b).
Patch coverage: 66.07% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##               qa     #875      +/-   ##
==========================================
+ Coverage   73.82%   75.61%   +1.79%     
==========================================
  Files          49       49              
  Lines        5348     5282      -66     
==========================================
+ Hits         3948     3994      +46     
+ Misses       1170     1055     -115     
- Partials      230      233       +3     
Impacted Files Coverage Δ
app/genesis.go 100.00% <ø> (ø)
clerk/genesis.go 75.00% <ø> (ø)
sidechannel/genesis.go 100.00% <ø> (ø)
sidechannel/keeper.go 86.95% <ø> (-7.96%) ⬇️
sidechannel/module.go 69.73% <ø> (-0.86%) ⬇️
app/state.go 42.42% <22.22%> (-1.20%) ⬇️
checkpoint/module.go 33.60% <33.33%> (-0.01%) ⬇️
clerk/side_handler.go 70.58% <33.33%> (-1.80%) ⬇️
checkpoint/side_handler.go 70.84% <37.50%> (-1.43%) ⬇️
auth/ante.go 81.87% <42.85%> (-1.37%) ⬇️
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions

github-actions Bot commented Nov 9, 2022

Copy link
Copy Markdown

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions Bot added the Stale label Nov 9, 2022
@temaniarpit27

Copy link
Copy Markdown
Contributor

@djpolygon can you check this once? Any updates on this or should we close this?

@github-actions github-actions Bot removed the Stale label Nov 18, 2022
…anges and mmigration to better packaging, future iterations are coming
@djpolygon djpolygon marked this pull request as ready for review November 23, 2022 15:17
@djpolygon djpolygon changed the base branch from develop to qa November 23, 2022 15:31
@cffls cffls merged commit af52cc8 into qa Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants