rpc/ethapi: stateDiff override visible to committed reads#157
Merged
Conversation
pratikspatil024
approved these changes
May 21, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Erigon's eth_call stateOverride.stateDiff only wrote dirtyStorage on the affected stateObject. GetCommittedState reads originStorage, so the override was invisible to EIP-2200's original-value read: SSTORE warm reset fell into the dirty branch (100 gas) instead of reset (2900 gas on Berlin onward, 2060 post-PIP-88). Bor doesn't hit this because their override applies SetState then statedb.Finalise, which promotes dirty into pending so GetCommittedState returns it.
Add IntraBlockState.SetStateOverride (writes both origin and dirty via stateObject.setCommittedStorage) and route the stateDiff loop through it. Mirrors Bor's post-Finalise semantics with a smaller surface change than porting Finalise itself, which would require chainRules and a StateWriter the override path can't supply.