Skip to content

txpool reorg locks#806

Closed
JekaMas wants to merge 4 commits into
developfrom
txpool-write-locks-on-reorg-reheap
Closed

txpool reorg locks#806
JekaMas wants to merge 4 commits into
developfrom
txpool-write-locks-on-reorg-reheap

Conversation

@JekaMas

@JekaMas JekaMas commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

Description

Please provide a detailed description of what was done in this PR

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@JekaMas JekaMas marked this pull request as draft April 4, 2023 05:45
@JekaMas JekaMas marked this pull request as ready for review April 4, 2023 10:52
@manav2401 manav2401 mentioned this pull request Apr 4, 2023
16 tasks
@manav2401

Copy link
Copy Markdown
Member

Closing this against #807

@manav2401 manav2401 closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants