Skip to content

Bumping control file versions#639

Merged
djpolygon merged 1 commit into
qafrom
djpolygon/3.2-beta_control
Dec 19, 2022
Merged

Bumping control file versions#639
djpolygon merged 1 commit into
qafrom
djpolygon/3.2-beta_control

Conversation

@djpolygon

Copy link
Copy Markdown
Contributor

Description

Please provide a detailed description of what was done in this PR

Changes

  • [x ] Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Bumping version in control files.

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@codecov

codecov Bot commented Dec 19, 2022

Copy link
Copy Markdown

Codecov Report

Base: 56.65% // Head: 56.66% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b7b1545) compared to base (7217f79).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##               qa     #639      +/-   ##
==========================================
+ Coverage   56.65%   56.66%   +0.01%     
==========================================
  Files         608      608              
  Lines       70470    70470              
==========================================
+ Hits        39924    39934      +10     
+ Misses      27126    27107      -19     
- Partials     3420     3429       +9     
Impacted Files Coverage Δ
les/pruner.go 60.71% <0.00%> (-3.58%) ⬇️
trie/trie.go 75.73% <0.00%> (-1.48%) ⬇️
consensus/ethash/sealer.go 78.64% <0.00%> (-1.46%) ⬇️
eth/protocols/snap/sync.go 70.30% <0.00%> (-1.43%) ⬇️
consensus/ethash/algorithm.go 88.81% <0.00%> (-1.32%) ⬇️
rpc/client.go 83.72% <0.00%> (-1.17%) ⬇️
p2p/simulations/network.go 57.76% <0.00%> (-0.88%) ⬇️
p2p/simulations/http.go 66.02% <0.00%> (-0.65%) ⬇️
eth/downloader/downloader.go 70.82% <0.00%> (-0.59%) ⬇️
trie/proof.go 73.59% <0.00%> (-0.36%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rekibnikufesin rekibnikufesin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@djpolygon djpolygon merged commit 205930e into qa Dec 19, 2022
@djpolygon djpolygon deleted the djpolygon/3.2-beta_control branch December 19, 2022 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants