update Docker login for goreleaser-cross v1.19#610
Merged
Conversation
temaniarpit27
approved these changes
Nov 30, 2022
Codecov ReportBase: 56.85% // Head: 56.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## qa #610 +/- ##
==========================================
- Coverage 56.85% 56.83% -0.03%
==========================================
Files 598 598
Lines 69214 69215 +1
==========================================
- Hits 39354 39338 -16
- Misses 26497 26526 +29
+ Partials 3363 3351 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Goreleaser-cross v1.19.x dropped support for authenticating to Docker Hub using environment variables. This PR uses the Docker Login GitHub action to authenticate for pushing images
Changes
Checklist
Cross repository changes
Testing
Manual tests
Untested. Unable to test without building the release. Implementation based on review of changes in goreleaser-cross commit history as seen here