CI: Optimize devnet setup#599
Merged
Merged
Conversation
POS-534 Optimize devnet setup
Currently, we hardcoded some wait time in the CI to wait for bor and heimdall to launch before deploying smart contracts. Example: A problem with this approach is that the hardcoded time could be too long than it actually requires, or it could be too short if initialization time of bor increases in the future. A better way to do this is to check the health of bor actively and remove 120 sleep time. |
temaniarpit27
approved these changes
Nov 30, 2022
marcello33
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously in CI, we had hardcoded wait time for bor to become operational before deploying the relevant contracts during devnet launch. This PR introduces constant monitoring of bor's status before contract deployment instead of a fixed wait period.
Changes
Checklist
Testing