Skip to content

Implemented gRPC client for heimdall#468

Merged
0xKrishna merged 8 commits into
developfrom
POS-648
Aug 3, 2022
Merged

Implemented gRPC client for heimdall#468
0xKrishna merged 8 commits into
developfrom
POS-648

Conversation

@0xKrishna

@0xKrishna 0xKrishna commented Jul 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR contains :

  1. gRPC client implementation for the Heimdall server
  2. Implemented all the methods in the current Heimdall interface

To use gRPC you have to pass gRPC server address using
--bor.heimdallgRPC=<address>
If you give the above flag then it will use gRPC, Otherwise it will continue to use REST APIs.

Default port in Heimdall is 3132
So for local the gRPC address is localhost:3132.

https://polygon.atlassian.net/browse/POS-648

@0xKrishna 0xKrishna marked this pull request as draft July 25, 2022 20:51
@codecov-commenter

codecov-commenter commented Jul 25, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #468 (fb17cda) into develop (6e8428b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #468      +/-   ##
===========================================
+ Coverage    56.93%   56.95%   +0.02%     
===========================================
  Files          607      607              
  Lines        69899    69906       +7     
===========================================
+ Hits         39794    39812      +18     
+ Misses       26697    26690       -7     
+ Partials      3408     3404       -4
Impacted Files Coverage Δ
internal/cli/server/config.go 73.61% <100.00%> (+0.12%) ⬆️
internal/cli/server/flags.go 100.00% <100.00%> (ø)
core/state/trie_prefetcher.go 74.80% <0.00%> (-5.35%) ⬇️
accounts/keystore/watch.go 90.69% <0.00%> (-4.66%) ⬇️
les/vflux/client/serverpool.go 76.76% <0.00%> (-1.66%) ⬇️
consensus/ethash/sealer.go 78.64% <0.00%> (-1.46%) ⬇️
core/rawdb/chain_iterator.go 58.38% <0.00%> (-1.25%) ⬇️
rpc/client.go 83.72% <0.00%> (-1.17%) ⬇️
consensus/ethash/consensus.go 40.21% <0.00%> (-1.07%) ⬇️
p2p/simulations/network.go 57.76% <0.00%> (-0.88%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8428b...fb17cda. Read the comment docs.

@0xKrishna 0xKrishna marked this pull request as ready for review July 26, 2022 12:38
manav2401
manav2401 reviewed Jul 26, 2022
View reviewed changes
Comment thread consensus/bor/heimdallgrpc/client.go Outdated
Comment thread consensus/bor/heimdallgrpc/span.go
JekaMas
JekaMas reviewed Jul 26, 2022
View reviewed changes
Comment thread consensus/bor/heimdallgrpc/state_sync.go
@0xKrishna 0xKrishna requested a review from manav2401 July 28, 2022 14:00
@0xKrishna 0xKrishna merged commit f42a70f into develop Aug 3, 2022
@0xKrishna 0xKrishna deleted the POS-648 branch August 3, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xsharma 0xsharma 0xsharma approved these changes

@manav2401 manav2401 manav2401 approved these changes

@marcello33 marcello33 Awaiting requested review from marcello33

+1 more reviewer

@JekaMas JekaMas JekaMas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@0xKrishna @codecov-commenter @JekaMas @0xsharma @manav2401