eth: fix multiple checkpoint fetch logic#465
Merged
Merged
Conversation
Contributor
|
Could you add a test for the issue? |
Member
Author
I actually tested this on a running node. But sure, I'll add some tests for this whole function to make it more deterministic. |
Codecov Report
@@ Coverage Diff @@
## develop #465 +/- ##
===========================================
+ Coverage 56.79% 56.90% +0.11%
===========================================
Files 605 609 +4
Lines 69942 69991 +49
===========================================
+ Hits 39723 39828 +105
+ Misses 26803 26763 -40
+ Partials 3416 3400 -16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
temaniarpit27
approved these changes
Aug 2, 2022
JekaMas
reviewed
Aug 2, 2022
JekaMas
reviewed
Aug 2, 2022
JekaMas
reviewed
Aug 2, 2022
JekaMas
approved these changes
Aug 2, 2022
JekaMas
approved these changes
Aug 11, 2022
Contributor
|
@temaniarpit27 I believe, we need that one in v0.3.0 |
temaniarpit27
approved these changes
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that was introduced in the RFC35 forkchoice implementaiton (#425). When the whitelisting service tries to fetch checkpoints, it fetches them in decreasing order starting from latest checkpoint to the oldest one. So, when a new checkpoint arrives, instead of eliminating the oldest checkpoint, it eliminated the latest one. We now fetch the checkpoints in an increasing order to prevent this from happening.