New CLI attach IPC.#361
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.3.0-dev #361 +/- ##
=============================================
Coverage ? 57.05%
=============================================
Files ? 558
Lines ? 66403
Branches ? 0
=============================================
Hits ? 37885
Misses ? 25313
Partials ? 3205 Continue to review full report at Codecov.
|
| if len(args) == 0 { | ||
| args = append(args, "") | ||
| } | ||
| if args[0] != "" && string(args[0][0:2]) == "--" { |
There was a problem hiding this comment.
| if args[0] != "" && string(args[0][0:2]) == "--" { | |
| if args[0] != "" && strings.HasPrefix(args, "--") { |
There was a problem hiding this comment.
Why do you use "--"? Can you add a description to the PR on how to use the command?
There was a problem hiding this comment.
Can you apply this https://github.com/maticnetwork/bor/pull/361/files#r832158323? Otherwise, it might panic if the size of the args is less than 2.
| if len(args) == 0 { | ||
| args = append(args, "") | ||
| } | ||
| if args[0] != "" && string(args[0][0:2]) == "--" { |
There was a problem hiding this comment.
Can you apply this https://github.com/maticnetwork/bor/pull/361/files#r832158323? Otherwise, it might panic if the size of the args is less than 2.
Refactored bor attach command.
bor attach <IPC file>is used to connect to remote console. It also includes flags such as--jspath,--preload,--exec.