Skip to content

Added bor fingerprint#308

Merged
0xsharma merged 4 commits into
v0.3.0-devfrom
feature-bor-fingerprint
Mar 16, 2022
Merged

Added bor fingerprint#308
0xsharma merged 4 commits into
v0.3.0-devfrom
feature-bor-fingerprint

Conversation

@0xsharma

Copy link
Copy Markdown
Member

Added bor fingerprint command to the new CLI. It works offline and shows all the properties listed in https://linear.app/matic/issue/POS-55/bor-fingerprint.

@0xsharma 0xsharma requested a review from ferranbt January 21, 2022 12:59

@ferranbt ferranbt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial review.

Comment thread internal/cli/bor_fingerprint.go Outdated
Comment thread internal/cli/bor_fingerprint.go Outdated
Comment thread internal/cli/bor_fingerprint.go Outdated
@0xsharma 0xsharma requested a review from ferranbt January 24, 2022 08:24
ssandeep
ssandeep previously approved these changes Feb 11, 2022
@0xsharma 0xsharma requested a review from vcastellm February 11, 2022 12:03
manav2401
manav2401 previously approved these changes Feb 14, 2022
vcastellm
vcastellm previously approved these changes Feb 15, 2022

@vcastellm vcastellm left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GLTM but please request against v0.3.0-dev

@0xsharma 0xsharma dismissed stale reviews from vcastellm, manav2401, and ssandeep via bd8cd1d February 16, 2022 09:41
@0xsharma 0xsharma changed the base branch from master to v0.3.0-dev February 16, 2022 09:47
@0xsharma

0xsharma commented Feb 16, 2022

Copy link
Copy Markdown
Member Author

GLTM but please request against v0.3.0-dev

Done @vcastellm !

Comment thread internal/cli/bor_fingerprint.go
@0xsharma 0xsharma requested a review from vcastellm February 16, 2022 12:16

@vcastellm vcastellm left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xsharma 0xsharma merged commit b8b9454 into v0.3.0-dev Mar 16, 2022
@temaniarpit27 temaniarpit27 deleted the feature-bor-fingerprint branch June 8, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants