Add ability to run using chain json file#306
Merged
Merged
Conversation
manav2401
reviewed
Jan 21, 2022
ferranbt
suggested changes
Jan 21, 2022
ferranbt
left a comment
Contributor
There was a problem hiding this comment.
Changes look good! One last thing, could you add a test for importChain so that we are sure that we can decode a chain in JSON format?
Contributor
Author
Done, Please let me know if anything is wrong, I haven't written too many test cases lately. |
ferranbt
suggested changes
Jan 24, 2022
ferranbt
left a comment
Contributor
There was a problem hiding this comment.
Looks good, only minor changes.
| "testing" | ||
| ) | ||
|
|
||
| func TestImportFromFile(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Rename to TestChain_ImportFromFile.
ferranbt
previously approved these changes
Jan 28, 2022
manav2401
previously approved these changes
Jan 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/matic/issue/POS-138/add-ability-to-run-any-genesis-chain-json-file