Skip to content

Backport from master to develop#2247

Merged
cffls merged 9 commits into
developfrom
merge_2.8.2
May 27, 2026
Merged

Backport from master to develop#2247
cffls merged 9 commits into
developfrom
merge_2.8.2

Conversation

@cffls

@cffls cffls commented May 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Backport v2.8.1 & v2.8.2 to develop

cffls and others added 9 commits May 26, 2026 20:54
Reject GetWitnessMetadata packets carrying more hashes than
MaxWitnessMetadataServe (1024) before iterating, matching the
per-request item caps used by maxHeadersServe / maxBodiesServe /
maxReceiptsServe in the eth protocol.

Co-authored-by: Manav Darji <manavdarji.india@gmail.com>
kurtosis-pos moved the setup and cleanup composite actions under
.github/actions/kurtosis/, so the bor workflows fail with "Can't find
action.yml" at the Pre/Post kurtosis run steps after checkout.

Update both kurtosis-e2e.yml and kurtosis-stateless-e2e.yml to use
./.github/actions/kurtosis/setup and ./.github/actions/kurtosis/cleanup.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* miner: track env.size in commitTransaction

env.size feeds txFitsSize for the params.MaxBlockSize cap. It was
seeded from header.Size() in makeEnv but never updated as transactions
were committed, so the cap was effectively inert.

* miner: set maxBlockSizeBufferZone to 1MB

* Bump up version to v2.8.2

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.50000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.85%. Comparing base (7fdfdb4) to head (e374aa1).

Files with missing lines Patch % Lines
eth/protocols/eth/handlers.go 30.00% 3 Missing and 4 partials ⚠️
core/evm.go 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (77.50%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2247      +/-   ##
===========================================
+ Coverage    52.84%   52.85%   +0.01%     
===========================================
  Files          886      886              
  Lines       156786   156811      +25     
===========================================
+ Hits         82848    82886      +38     
+ Misses       68688    68663      -25     
- Partials      5250     5262      +12     
Files with missing lines Coverage Δ
consensus/bor/statefull/processor.go 78.62% <100.00%> (+0.14%) ⬆️
core/blockchain.go 62.39% <100.00%> (+0.18%) ⬆️
eth/handler_wit.go 79.47% <100.00%> (+0.41%) ⬆️
eth/protocols/eth/receipt.go 79.57% <100.00%> (+0.89%) ⬆️
miner/worker.go 77.72% <100.00%> (+0.06%) ⬆️
params/version.go 23.68% <ø> (ø)
core/evm.go 70.53% <0.00%> (-1.29%) ⬇️
eth/protocols/eth/handlers.go 49.37% <30.00%> (-0.18%) ⬇️

... and 24 files with indirect coverage changes

Files with missing lines Coverage Δ
consensus/bor/statefull/processor.go 78.62% <100.00%> (+0.14%) ⬆️
core/blockchain.go 62.39% <100.00%> (+0.18%) ⬆️
eth/handler_wit.go 79.47% <100.00%> (+0.41%) ⬆️
eth/protocols/eth/receipt.go 79.57% <100.00%> (+0.89%) ⬆️
miner/worker.go 77.72% <100.00%> (+0.06%) ⬆️
params/version.go 23.68% <ø> (ø)
core/evm.go 70.53% <0.00%> (-1.29%) ⬇️
eth/protocols/eth/handlers.go 49.37% <30.00%> (-0.18%) ⬇️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cffls cffls merged commit d99ab21 into develop May 27, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants