core/blockstm: remove old UpdateDeps DAG algorithm#2168
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
There was a problem hiding this comment.
Pull request overview
Removes the legacy BlockSTM dependency-DAG construction path (UpdateDeps/GetDep) now that DepsBuilder is the active algorithm, and updates the profiling/metadata path to use DepsBuilder as well.
Changes:
- Replace profiling-path
GetDep(*pe.lastTxIO)usage with incrementalDepsBuilderconstruction. - Delete the now-dead
TxDep,depsHelper,UpdateDeps, andGetDepcode. - Remove the old equivalence test and
UpdateDepsbenchmark, keepingDepsBuilderbenchmark coverage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
core/blockstm/executor.go |
Switch profiling dependency-graph generation to DepsBuilder. |
core/blockstm/dag.go |
Remove obsolete dependency-building types/functions tied to the old algorithm. |
core/blockstm/dag_test.go |
Drop tests/benchmarks that depended on the removed old algorithm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2168 +/- ##
===========================================
- Coverage 51.90% 51.87% -0.03%
===========================================
Files 884 884
Lines 155357 155324 -33
===========================================
- Hits 80631 80579 -52
- Misses 69518 69533 +15
- Partials 5208 5212 +4
... and 15 files with indirect coverage changes
🚀 New features to boost your workflow:
|
Description
The DepsBuilder algorithm introduced in #2094 replaced
UpdateDeps/GetDepin the hot path. Removed the now-dead TxDep, depsHelper, UpdateDeps, and GetDep functions, replaced the profiling-path GetDep call in executor.go with DepsBuilder, and dropped the equivalence test and UpdateDeps benchmark.