Skip to content

added giugliano block for mainnet#2164

Merged
pratikspatil024 merged 2 commits intov2.7.0-candidatefrom
giugliano-mainnet
Mar 26, 2026
Merged

added giugliano block for mainnet#2164
pratikspatil024 merged 2 commits intov2.7.0-candidatefrom
giugliano-mainnet

Conversation

@pratikspatil024
Copy link
Copy Markdown
Member

@pratikspatil024 pratikspatil024 commented Mar 26, 2026

Description

https://polygonscan.com/block/countdown/85268500

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

Copilot AI review requested due to automatic review settings March 26, 2026 11:03
claude[bot]
claude bot reviewed Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

Tip: disable this comment in your organization's Code Review settings.

@pratikspatil024 pratikspatil024 mentioned this pull request Mar 26, 2026
Merged
@claude
Copy link
Copy Markdown

claude bot commented Mar 26, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Copilot AI reviewed Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the Giugliano Bor hardfork activation block to Polygon PoS mainnet configuration, aligning runtime chain configs and the builder genesis spec with the announced activation height.

Changes:

  • Set GiuglianoBlock to 85268500 in Bor mainnet chain config (params/config.go).
  • Mirror the same activation block in the CLI mainnet chain spec (internal/cli/server/chains/mainnet.go).
  • Add giuglianoBlock to the mainnet genesis builder JSON (builder/files/genesis-mainnet-v1.json).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
params/config.go Adds Giugliano hardfork activation height to Bor mainnet chain config.
internal/cli/server/chains/mainnet.go Keeps CLI-provided mainnet chain spec in sync with the updated Bor config.
builder/files/genesis-mainnet-v1.json Updates the builder genesis config to include the Giugliano activation block.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

marcello33
marcello33 approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@marcello33 marcello33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just please address the copilot concern to GatherForks

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 26, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
40.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.30%. Comparing base (1a59b5e) to head (76e3086).
⚠️ Report is 1 commits behind head on v2.7.0-candidate.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           v2.7.0-candidate    #2164      +/-   ##
====================================================
- Coverage             51.34%   51.30%   -0.04%     
====================================================
  Files                   882      882              
  Lines                154210   154212       +2     
====================================================
- Hits                  79172    79120      -52     
- Misses                69892    69941      +49     
- Partials               5146     5151       +5
Files with missing lines Coverage Δ
core/forkid/forkid.go 76.58% <100.00%> (+0.23%) ⬆️
params/config.go 36.81% <ø> (ø)

... and 13 files with indirect coverage changes

Files with missing lines Coverage Δ
core/forkid/forkid.go 76.58% <100.00%> (+0.23%) ⬆️
params/config.go 36.81% <ø> (ø)

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pratikspatil024 pratikspatil024 merged commit 2a3651f into v2.7.0-candidate Mar 26, 2026
16 of 18 checks passed
@pratikspatil024 pratikspatil024 deleted the giugliano-mainnet branch March 26, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@claude claude[bot] claude[bot] left review comments

@lucca30 lucca30 lucca30 approved these changes

@marcello33 marcello33 marcello33 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pratikspatil024 @lucca30 @marcello33