Skip to content

witness: disable filestore by default#2144

Merged
pratikspatil024 merged 1 commit intov2.7.0-candidatefrom
psp-disable-witness-fs
Mar 19, 2026
Merged

witness: disable filestore by default#2144
pratikspatil024 merged 1 commit intov2.7.0-candidatefrom
psp-disable-witness-fs

Conversation

@pratikspatil024
Copy link
Copy Markdown
Member

@pratikspatil024 pratikspatil024 commented Mar 18, 2026

Description

We observed on Amoy that filestore witness write is taking more time than legacy db write.
Disabling by default for now, will debug later.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

claude[bot]
claude bot reviewed Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

@pratikspatil024 pratikspatil024 requested review from a team and cffls March 18, 2026 14:51
@claude
Copy link
Copy Markdown

claude bot commented Mar 18, 2026

Code Review

1 issue found:

Stale generated docs (CLAUDE.md compliance): The FileStore default was changed from true to false in DefaultConfig(), but the generated documentation files were not updated. docs/cli/default_config.toml (line 238) still shows filestore = true and docs/cli/server.md (line 121) still shows (default: true). Per CLAUDE.md (Essential Commands section), make docs should be run to regenerate CLI docs and default config after changes to DefaultConfig().

@pratikspatil024 pratikspatil024 force-pushed the psp-disable-witness-fs branch from 29ad548 to 945ad85 Compare March 18, 2026 14:59
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 18, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v2.7.0-candidate@9dbbecf). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##             v2.7.0-candidate    #2144   +/-   ##
===================================================
  Coverage                    ?   51.54%           
===================================================
  Files                       ?      882           
  Lines                       ?   154140           
  Branches                    ?        0           
===================================================
  Hits                        ?    79453           
  Misses                      ?    69517           
  Partials                    ?     5170
Files with missing lines Coverage Δ
internal/cli/server/config.go 64.97% <100.00%> (ø)
Files with missing lines Coverage Δ
internal/cli/server/config.go 64.97% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pratikspatil024 pratikspatil024 merged commit 2b949e9 into v2.7.0-candidate Mar 19, 2026
15 of 16 checks passed
@pratikspatil024 pratikspatil024 deleted the psp-disable-witness-fs branch March 19, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@cffls cffls cffls approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pratikspatil024 @cffls