Skip to content

added giugliano block for amoy#2141

Merged
pratikspatil024 merged 1 commit intov2.7.0-candidatefrom
giugliano-amoy
Mar 16, 2026
Merged

added giugliano block for amoy#2141
pratikspatil024 merged 1 commit intov2.7.0-candidatefrom
giugliano-amoy

Conversation

@pratikspatil024
Copy link
Copy Markdown
Member

@pratikspatil024 pratikspatil024 commented Mar 16, 2026

Description

https://amoy.polygonscan.com/block/countdown/35573500

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@claude
Copy link
Copy Markdown

claude bot commented Mar 16, 2026

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 16, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
66.7% Duplication on New Code

See analysis details on SonarQube Cloud

@claude
Copy link
Copy Markdown

claude bot commented Mar 16, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v2.7.0-candidate@9ef5449). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##             v2.7.0-candidate    #2141   +/-   ##
===================================================
  Coverage                    ?   51.51%           
===================================================
  Files                       ?      882           
  Lines                       ?   154140           
  Branches                    ?        0           
===================================================
  Hits                        ?    79411           
  Misses                      ?    69548           
  Partials                    ?     5181
Files with missing lines Coverage Δ
params/config.go 36.81% <ø> (ø)
Files with missing lines Coverage Δ
params/config.go 36.81% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pratikspatil024 pratikspatil024 merged commit c557c52 into v2.7.0-candidate Mar 16, 2026
12 checks passed
@pratikspatil024 pratikspatil024 deleted the giugliano-amoy branch March 16, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucca30 lucca30 lucca30 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pratikspatil024 @lucca30