Including Missing Metrics from Import Blocks path into Production#2139
Merged
pratikspatil024 merged 3 commits intodevelopfrom Mar 13, 2026
Merged
Including Missing Metrics from Import Blocks path into Production#2139pratikspatil024 merged 3 commits intodevelopfrom
pratikspatil024 merged 3 commits intodevelopfrom
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (88.52%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #2139 +/- ##
===========================================
+ Coverage 51.50% 51.52% +0.02%
===========================================
Files 882 882
Lines 154081 154139 +58
===========================================
+ Hits 79352 79415 +63
+ Misses 69552 69543 -9
- Partials 5177 5181 +4
... and 20 files with indirect coverage changes
🚀 New features to boost your workflow:
|
|
cffls
approved these changes
Mar 12, 2026
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
pratikspatil024
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By default Geth has a good sort of metrics included on the flow of importing blocks while keep a gap on the same metrics for the worker. This task aims to mirror the missing metrics which were worth, to bring more visibility for future cases.
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it