internal/cli, node, rpc: port missing geth flags#2106
Merged
kamuikatsurgi merged 5 commits intodevelopfrom Mar 5, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2106 +/- ##
===========================================
+ Coverage 51.27% 51.29% +0.01%
===========================================
Files 878 878
Lines 152669 152665 -4
===========================================
+ Hits 78283 78302 +19
+ Misses 69283 69269 -14
+ Partials 5103 5094 -9
... and 18 files with indirect coverage changes
🚀 New features to boost your workflow:
|
manav2401
reviewed
Mar 5, 2026
|
manav2401
approved these changes
Mar 5, 2026
marcello33
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Flags added:
--rpc.batch-request-limit/--rpc.batch-response-max-size- Geth's node.Config fields used in every RPC handler were never set by bor, always defaulting to zero (no limits).--vmtrace/--vmtrace.jsonconfig-eth/backend.gouses these to create a live tracer at startup; bor never wired them.Bor's
RPCBatchLimitwas only applied toHTTPservers viahttpServer.SetRPCBatchLimit(), it was never applied toWebSocketorIPChandlers. Geth'sBatchRequestLimit/BatchResponseMaxSizeare set on the in-process handler and passed to every RPC handler, includingWSandIPC.