Skip to content

internal/cli, packaging, docs: add config.toml updater, refresh templates, and document workflow#2100

Merged
kamuikatsurgi merged 6 commits intodevelopfrom
chore/config-toml-updater
Mar 3, 2026
Merged

internal/cli, packaging, docs: add config.toml updater, refresh templates, and document workflow#2100
kamuikatsurgi merged 6 commits intodevelopfrom
chore/config-toml-updater

Conversation

@kamuikatsurgi
Copy link
Copy Markdown
Member

@kamuikatsurgi kamuikatsurgi commented Mar 3, 2026

Description

  • Added a new Bor config updater at scripts/update-config-toml/main.go to keep config.toml templates aligned with the current server.DefaultConfig() and config schema.
  • Updater now merges existing file values on top of defaults (preserves intentional overrides), fills missing keys, and rewrites files in a consistent format.
  • Regenerated Bor config templates with improved comments/formatting and synced defaults.
  • Documented workflow in CLAUDE.md (dry-run/apply commands, verification expectations, and failure-handling guidance).

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.23%. Comparing base (82b9c74) to head (12b1bea).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2100      +/-   ##
===========================================
+ Coverage    51.17%   51.23%   +0.05%     
===========================================
  Files          878      878              
  Lines       152499   152444      -55     
===========================================
+ Hits         78041    78098      +57     
+ Misses       69350    69258      -92     
+ Partials      5108     5088      -20     
Files with missing lines Coverage Δ
internal/cli/bootnode.go 0.00% <ø> (ø)
internal/cli/server/command.go 35.26% <ø> (+1.06%) ⬆️
internal/cli/server/config.go 63.74% <ø> (-0.04%) ⬇️
internal/cli/server/flags.go 100.00% <100.00%> (ø)
internal/cli/server/server.go 30.52% <ø> (+1.45%) ⬆️

... and 16 files with indirect coverage changes

Files with missing lines Coverage Δ
internal/cli/bootnode.go 0.00% <ø> (ø)
internal/cli/server/command.go 35.26% <ø> (+1.06%) ⬆️
internal/cli/server/config.go 63.74% <ø> (-0.04%) ⬇️
internal/cli/server/flags.go 100.00% <100.00%> (ø)
internal/cli/server/server.go 30.52% <ø> (+1.45%) ⬆️

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@manav2401 manav2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Few small nits.

  • Might be good to add this in Makefile under the make docs field - we anyways run that to update docs.
  • There's too much context about this in CLAUDE.md which I am not sure is needed. We should remove it or trim it down to a line or two (with just the make docs command maybe).

@kamuikatsurgi
Copy link
Copy Markdown
Member Author

LGTM. Few small nits.

  • Might be good to add this in Makefile under the make docs field - we anyways run that to update docs.
  • There's too much context about this in CLAUDE.md which I am not sure is needed. We should remove it or trim it down to a line or two (with just the make docs command maybe).

Done.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 3, 2026

Copy link
Copy Markdown
Member

@pratikspatil024 pratikspatil024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whichever release this PR goes into, make sure to add a note stating that log-level is deprecated, and if they are using it in the config file, it would either not take effect/node would not start (please confirm if the note starts or not if we have this outdated flag in the config)

@kamuikatsurgi kamuikatsurgi merged commit ba46e15 into develop Mar 3, 2026
23 checks passed
@kamuikatsurgi kamuikatsurgi deleted the chore/config-toml-updater branch March 3, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants