Skip to content

consensus, crypto, p2p: fix issues 44, 47, 48, 49#2059

Merged
marcello33 merged 5 commits intomasterfrom
v2.5.9-candidate
Feb 17, 2026
Merged

consensus, crypto, p2p: fix issues 44, 47, 48, 49#2059
marcello33 merged 5 commits intomasterfrom
v2.5.9-candidate

Conversation

@marcello33
Copy link
Copy Markdown
Collaborator

Description

Fixes for issues 44, 47, 48 and 49

@marcello33 marcello33 requested a review from a team February 17, 2026 15:23
Copy link
Copy Markdown
Member

@kamuikatsurgi kamuikatsurgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 22.22222% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.03%. Comparing base (d4a38a4) to head (e18de16).
⚠️ Report is 41 commits behind head on master.

Files with missing lines Patch % Lines
consensus/bor/heimdallgrpc/state_sync.go 0.00% 36 Missing ⚠️
crypto/secp256k1/curve.go 0.00% 8 Missing ⚠️
crypto/crypto.go 0.00% 2 Missing and 1 partial ⚠️
consensus/bor/bor.go 75.00% 0 Missing and 1 partial ⚠️
consensus/clique/clique.go 75.00% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (22.22%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2059      +/-   ##
==========================================
+ Coverage   47.91%   48.03%   +0.11%     
==========================================
  Files         844      842       -2     
  Lines      144132   144510     +378     
==========================================
+ Hits        69068    69418     +350     
- Misses      70530    70538       +8     
- Partials     4534     4554      +20     
Files with missing lines Coverage Δ
consensus/misc/eip1559/eip1559.go 80.30% <100.00%> (+2.71%) ⬆️
p2p/discover/v4wire/v4wire.go 37.61% <100.00%> (+9.04%) ⬆️
params/version.go 23.68% <ø> (ø)
consensus/bor/bor.go 25.73% <75.00%> (+2.80%) ⬆️
consensus/clique/clique.go 41.66% <75.00%> (+0.80%) ⬆️
crypto/crypto.go 70.00% <0.00%> (-1.34%) ⬇️
crypto/secp256k1/curve.go 20.10% <0.00%> (-0.76%) ⬇️
consensus/bor/heimdallgrpc/state_sync.go 0.00% <0.00%> (ø)

... and 20 files with indirect coverage changes

Files with missing lines Coverage Δ
consensus/misc/eip1559/eip1559.go 80.30% <100.00%> (+2.71%) ⬆️
p2p/discover/v4wire/v4wire.go 37.61% <100.00%> (+9.04%) ⬆️
params/version.go 23.68% <ø> (ø)
consensus/bor/bor.go 25.73% <75.00%> (+2.80%) ⬆️
consensus/clique/clique.go 41.66% <75.00%> (+0.80%) ⬆️
crypto/crypto.go 70.00% <0.00%> (-1.34%) ⬇️
crypto/secp256k1/curve.go 20.10% <0.00%> (-0.76%) ⬇️
consensus/bor/heimdallgrpc/state_sync.go 0.00% <0.00%> (ø)

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marcello33 marcello33 merged commit f73798e into master Feb 17, 2026
9 of 11 checks passed
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants