Skip to content

Enable block stm for non witness producers#1911

Merged
lucca30 merged 1 commit intodevelopfrom
lmartins/block-stm-non-witness-generation
Nov 26, 2025
Merged

Enable block stm for non witness producers#1911
lucca30 merged 1 commit intodevelopfrom
lmartins/block-stm-non-witness-generation

Conversation

@lucca30
Copy link
Copy Markdown
Contributor

@lucca30 lucca30 commented Nov 26, 2025

Description

The only reason we disabled BlockSTM were we found issues while developing the witness feature. It's known now the issue is just because of the speculative nature of the parallel work which prefetches more nodes than necessary when building the witness.
So here we enable this feature back since:

  • 74.9% were faster on BlockSTM
    • Avg of 12% faster, which means 27ms
  • For big blocks (45 Million gas +)
    • 63% of them were faster with block STM
    • The best case covered gained 52ms
image image

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@lucca30 lucca30 requested a review from a team November 26, 2025 18:06
@sonarqubecloud
Copy link
Copy Markdown

@lucca30 lucca30 merged commit 2229ae7 into develop Nov 26, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants