Skip to content

(feat): allow miner gas tip override#1889

Merged
manav2401 merged 3 commits intodevelopfrom
reduced-miner-gasprice-for-bps
Nov 19, 2025
Merged

(feat): allow miner gas tip override#1889
manav2401 merged 3 commits intodevelopfrom
reduced-miner-gasprice-for-bps

Conversation

@manav2401
Copy link
Copy Markdown
Member

@manav2401 manav2401 commented Nov 18, 2025

Description

Adds a new flag --allow-gas-tip-override to allow block producers to use a different value instead of enforcing the default 25 gwei. The aim is to allow block producers to set a slightly lower value than default to handle some edge cases where transactions priced exactly at 25 gwei (or slightly more) are mineable and they don't bloat the pool.

Note that rpc providers should fallback to default so any transaction with a gas tip lower than 25 gwei will be rejected.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@manav2401 manav2401 requested a review from a team November 18, 2025 07:06
Copy link
Copy Markdown
Contributor

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! One minor comment about the flag naming.

@manav2401 manav2401 changed the title (feat): add is active producer flag to allow config modifications (feat): allow gas tip override Nov 19, 2025
@manav2401 manav2401 changed the title (feat): allow gas tip override (feat): allow miner gas tip override Nov 19, 2025
@sonarqubecloud
Copy link
Copy Markdown

@manav2401 manav2401 merged commit d8375fa into develop Nov 19, 2025
9 of 11 checks passed
@manav2401 manav2401 deleted the reduced-miner-gasprice-for-bps branch November 19, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants