Skip to content

consensus, internal: don't limit gas cap for system txns#1865

Merged
manav2401 merged 2 commits intodevelopfrom
manav/gaslimit-for-system-txs
Nov 10, 2025
Merged

consensus, internal: don't limit gas cap for system txns#1865
manav2401 merged 2 commits intodevelopfrom
manav/gaslimit-for-system-txs

Conversation

@manav2401
Copy link
Copy Markdown
Member

@manav2401 manav2401 commented Nov 4, 2025

Description

This PR lifts any cap applied over system transactions which happen during bor consensus.

While writes follow a different route, all the reads needed from genesis contracts during consensus go through the normal eth_call route. This PR sets a (uint64.Max/2) gas limit for system transactions and bypasses any cap being put on them (which can otherwise lead to consensus failure in rare cases if capped).

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 4, 2025

@manav2401 manav2401 merged commit 81bcc2d into develop Nov 10, 2025
10 of 15 checks passed
@manav2401 manav2401 deleted the manav/gaslimit-for-system-txs branch November 10, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants