Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new backfill-statesync-txs command that allows backfilling missing StateSync transaction data and receipts from a trusted JSON file into the database. The command validates the input file, checks for missing data in the database, and only inserts entries that don't already exist.
- Implements comprehensive validation of StateSync data including consecutiveness checks for StateSync IDs
- Adds parallel processing for efficient database checking and batched writes
- Includes proper error handling and progress reporting throughout the backfill process
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/cli/command.go | Registers the new backfill command in the CLI command map |
| internal/cli/backfill_statesync_txs.go | Main implementation with validation, parsing, and database operations |
| docs/cli/backfill_statesync_txs.md | Documentation for the new command |
| core/rawdb/bor_receipt.go | Updates nil check to use len(data) != 0 for consistency |
| core/rawdb/accessors_chain.go | Minor formatting cleanup removing blank line |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kamuikatsurgi
approved these changes
Sep 25, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
cffls
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
backfill-statesync-txscommand receives a trusted file containing statesync txs and events from a time period and backfill it into the database. It walks over the block period checking any missing data and backfilling them. It writes just over KV database, which means the data which were supposed to already be on ancient will be now always at ancient.Changes