Larger tx announce queue for trusted peers#1781
Conversation
Allows the node to allocate more buffer (x10) for txn announcements for trusted and static peers. Larger queue reduces the possibility a transaction might get dropped by the node when there is a surge of txns in the network.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2.3.0-candidate #1781 +/- ##
===================================================
Coverage ? 48.29%
===================================================
Files ? 828
Lines ? 136502
Branches ? 0
===================================================
Hits ? 65921
Misses ? 66333
Partials ? 4248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pratikspatil024
left a comment
There was a problem hiding this comment.
LGTM, maybe worth adding a comment stating that this is specific to Polygon, so that it should not be removed accidentally during upstream merge.
Thanks, addressed in the comment. |
|
|
|
||
| queueLimit := maxQueuedTxAnns | ||
| if p.IsTrusted() || p.IsStatic() { | ||
| queueLimit = maxQueuedTxAnnsTrusted |
There was a problem hiding this comment.
Should we have just considered 10x maxQueuedTxAnns rather than defining another const?
Description
Allows the node to allocate more buffer (x10) for txn announcements for trusted and static peers. Larger queue reduces the possibility a transaction might get dropped by the node when there is a surge of txns in the network.
Changes