Start GRPC server after backend assignment#1637
Merged
pratikspatil024 merged 6 commits intov2.2.9-candidatefrom Jul 16, 2025
Merged
Start GRPC server after backend assignment#1637pratikspatil024 merged 6 commits intov2.2.9-candidatefrom
pratikspatil024 merged 6 commits intov2.2.9-candidatefrom
Conversation
Contributor
|
Looks like a unit test has failed. lgtm otherwise. |
Contributor
Author
|
Hum, that's true. Fixing it. Thanks |
cffls
approved these changes
Jul 16, 2025
pratikspatil024
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug of a time window at startup which
s.backend == nil, which causes panic in any GRPC call if enabled by heimdall and queried right after starting bor.It was reported on this issue
Changes